-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync all unstable features with Unstable Book; add tidy lint. #40694
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
685425a
to
fc22d6e
Compare
r? @rust-lang/docs |
Urg, that's a LOT of code! Fine by me otherwise. |
@GuillaumeGomez Which code are you talking about? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but one stylistic issue
|
||
[#37340]: https://github.com/rust-lang/rust/issues/37340 | ||
|
||
------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, I purposefully put these at the end of sections that do not have docs, just to keep it consistent; would you mind updating the ones you've added to have this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in the latest force push.
☔ The latest upstream changes (presumably #40693) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm confused by the deletion of |
@stjepang |
Oh, the implementation of the feature landed five days ago. Huh, I'll have to check why my tidy lint wanted it deleted. Good catch |
Actually, the PR for the feature was submitted 5 days ago, and it landed an hour ago. |
fc22d6e
to
a294a32
Compare
Anyone else see anything? If everything looks good, just give me a "r=me" thing. I don't want to approve this until after #40619 merges. |
☔ The latest upstream changes (presumably #40748) made this pull request unmergeable. Please resolve the merge conflicts. |
a294a32
to
5baaa80
Compare
#40619 merged. This is ready to go now. r? @steveklabnik |
I have no idea what Travis is getting hung up on here. If anyone has thoughts, let me know. |
5baaa80
to
04d6641
Compare
I don't want this to bit-rot while I try to debug this, so I extracted all the non-tidy-lint changes into a new PR: #40786 |
Add all unstable features to the Unstable Book, also remove a few that either no longer exist or were promoted to stable. These changes were extracted out of rust-lang#40694
…atures, r=steveklabnik Add all unstable features to Unstable Book. Add all unstable features to the Unstable Book, also remove a few that either no longer exist or were promoted to stable. These changes were extracted out of rust-lang#40694
04d6641
to
09ff832
Compare
This should be ready to go now. |
@bors retry timed out while trying to connect to github |
⌛ Testing commit 53b35bd with merge 6acc9bf... |
💔 Test failed - status-travis |
@bors retry |
⌛ Testing commit 53b35bd with merge 09f9d21... |
Add a tidy lint that checks for... * Unstable Book sections with no corresponding SUMMARY.md links * unstable features that don't have Unstable Book sections * Unstable Book sections that don't have corresponding unstable features
53b35bd
to
eef2a95
Compare
@bors r=steveklabnik p=1 new feature got added a few hours ago going to give this a p=1 to make sure this stops getting out of sync |
📌 Commit eef2a95 has been approved by |
…teveklabnik Sync all unstable features with Unstable Book; add tidy lint. Add a tidy lint that checks for... * Unstable Book sections with no corresponding SUMMARY.md links * unstable features that don't have Unstable Book sections * Unstable Book sections that don't have corresponding unstable features
Add a tidy lint that checks for...